Inline utils from rules_docker go pkg#725
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mrmeku The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @@ -12,7 +12,6 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/bazelbuild/rules_docker/container/go/pkg/compat" | |||
There was a problem hiding this comment.
what about this one, should it be inlined too? I guess you'll have a later PR to drop the go_repository that fetches rules_docker code. I don't know what is the maintenance story for rules_k8s so maybe we should wait-and-see if we get any responses.
There was a problem hiding this comment.
Yeah, maybe that one should also be inlined as part of this change. I had held off since that particular import needs to be translated to understand the OCI image format rather than the format rules_docker is outputting today. But that translation could easily be done in a followup PR after inlining in this one
|
@chases2 hi, are you the maintainer here? |
For #723