bindgen: remove extra trailing space in check for --rust-edition flags #3799
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments would be passed as either `--rust-edition=2024` or `--rust-edition`, `2024`, but either way the resulting entry from the list comprehension on the right hand of the `not in` operator will contain `"--rust-edition"` without the trailing space. This allows users of the bindgen rules to specify their own explicit edition. Tested: Works in our private repo, and didn't without this patch.
Contributor
Author
|
Failure looks strange and probably unrelated? looks like it's trying to do a release action or something on my PR? |
Contributor
Author
|
Oh, I see other failures but they all look weird and environmental to me. Please let me know if I missed a real one in my search. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments would be passed as either
--rust-edition=2024or--rust-edition,2024, but either way the resulting entry from the list comprehension on the right hand of thenot inoperator will contain"--rust-edition"without the trailing space. This allows users of the bindgen rules to specify their own explicit edition.Tested:
Works in our private repo, and didn't without this patch.