Open
Conversation
Author
|
The important part is the new function "reductor", which adjusts the offset depending on the zoom-level |
|
Very nice fix! Unfortunately I dont understand why that is the case, but I found a function that would work: It would probably also be nice to be able to define the exponent (hard coded 2 here). I for example would prefer a value of 1.3. for the current task. |
ryankerrad
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is based on the pull request from @Sijmen, and provides an additional fix for the circles that still appear on zoomout.
This works for my current usage, as it assumes the maximum zoom level is 18 and the map is globally available via Window.map, further work may be needed before it can be used as is, but it can be useful for others.