-
Notifications
You must be signed in to change notification settings - Fork 0
Update vega #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vega #131
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
- Coverage 92.71% 92.17% -0.54%
==========================================
Files 86 86
Lines 1496 1496
Branches 225 225
==========================================
- Hits 1387 1379 -8
- Misses 91 98 +7
- Partials 18 19 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look/respond to my comment. Does it works fine with xcube-viewer too? There is one test for VegaChart that is missing in the Github CI, is that intentional?
This PR updates vega to v6 and its corresponding dependencies.