Business filer DRS integration

[flutistar]

Issue #: /bcgov/entity#28412
Description of changes:

• Create a DRS record upon staff filing.
• Feature flag has been implemented.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[doug-lovett]

Looks good.

[thorwolpert]

Shouldn't the DRS stuff be in it's own service rather than utils business_filer/services/utils.py ?

[flutistar]

Shouldn't the DRS stuff be in it's own service rather than utils business_filer/services/utils.py ?

I think it's doable, but I felt it was over-engineering since it's just a single function that creates a DRS record upon staff filing.
If it grows in complexity later, we can definitely move it into its own service.

[thorwolpert]

Shouldn't the DRS stuff be in it's own service rather than utils business_filer/services/utils.py ?

I think it's doable, but I felt it was over-engineering since it's just a single function that creates a DRS record upon staff filing. If it grows in complexity later, we can definitely move it into its own service.

i think it would be better now than later. it's not really a generic util thing.

[flutistar]

Shouldn't the DRS stuff be in it's own service rather than utils business_filer/services/utils.py ?

I think it's doable, but I felt it was over-engineering since it's just a single function that creates a DRS record upon staff filing. If it grows in complexity later, we can definitely move it into its own service.

i think it would be better now than later. it's not really a generic util thing.

Done

[vysakh-menon-aot]

Shouldn't the DRS stuff be in it's own service rather than utils business_filer/services/utils.py ?

I think it's doable, but I felt it was over-engineering since it's just a single function that creates a DRS record upon staff filing. If it grows in complexity later, we can definitely move it into its own service.

i think it would be better now than later. it's not really a generic util thing.

Done

I believe @thorwolpert point is to create a new pub sub service instead of doing it here.

[flutistar]

Shouldn't the DRS stuff be in it's own service rather than utils business_filer/services/utils.py ?

I think it's doable, but I felt it was over-engineering since it's just a single function that creates a DRS record upon staff filing. If it grows in complexity later, we can definitely move it into its own service.

i think it would be better now than later. it's not really a generic util thing.

Done

I believe @thorwolpert point is to create a new pub sub service instead of doing it here.

Well, I was initially thinking the same as you, @vysakh-menon-aot , but based on his latest comment, it seems like just moving it into its own service file. Also, I’d clarify that the integration is actually part of finalizing the filing process for staff filings, rather than a separate piece of logic.