Skip to content

Conversation

@Rajandeep98
Copy link
Collaborator

Issue #: /bcgov/entity#31096

Description of changes:
Skip Events which are not completed
event 1 -> event2
event2 -> null [skip] (currently in name change its returning null -> null )
event 2 -> event3

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

and (end_event_id is null or end_event_id >= {event_id})
and corp_name_typ_cd in ('CO', 'NB')
order by start_event_id desc
limit 1) = null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
limit 1) = null
limit 1) is null

Copy link
Collaborator

@vysakh-menon-aot vysakh-menon-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot visualize the impact of this. please test with different scenario to make sure its not missing any data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants