Skip to content

Fix bugs#2547

Merged
Fosol merged 1 commit intobcgov:devfrom
Fosol:fixes
Jan 25, 2026
Merged

Fix bugs#2547
Fosol merged 1 commit intobcgov:devfrom
Fosol:fixes

Conversation

@Fosol
Copy link
Collaborator

@Fosol Fosol commented Jan 25, 2026

Three bug fixes.

  • DevOps script to deploy to PROD needed to be updated
  • Anonymous API endpoint that returns images failed if the query string was invalid or didn't include a file extension
  • Reporting engine wasn't URL encoding the path correctly

@Fosol Fosol self-assigned this Jan 25, 2026
@Fosol Fosol added bug Something isn't working devops DevOps templates, documentation, configuration, tools. subscriber PR contains changes towards the subscriber application, labels Jan 25, 2026
public IActionResult AnonymousDownloadFile(string path)
{
var ext = Path.GetExtension(path).Substring(1);
var ext = Path.GetExtension(path).TrimStart('.');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue when the file doesn't include an extension


await File.WriteAllBytesAsync(fullPath, imageBytes);

var urlPathToImage = WebUtility.UrlEncode(pathToImage);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bug when file name includes invalid characters like &, ?, =

podsContent=$(getPods content-service deployment $env)
podsIndexing=$(getPods indexing-service deployment $env)
if [ "$env" != "dev "]; then
if [[ "$env" != "dev " ]]; then
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed DevOps bug

@Fosol Fosol merged commit e494636 into bcgov:dev Jan 25, 2026
1 check passed
@Fosol Fosol deleted the fixes branch January 25, 2026 07:09
Fosol added a commit to Fosol/tno that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working devops DevOps templates, documentation, configuration, tools. subscriber PR contains changes towards the subscriber application,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant