Open
Conversation
e3860ca to
5d0c173
Compare
Box<dyn Format>
Author
|
@bcmyers This still maintained? |
Author
|
Already contained in #47, which also fixes other problems. |
Author
|
Actually, not completely contained in #47, so I'll keep this open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
I would like to be able to switch between a
Localeand aSystemLocaleat runtime. Therefore I would like to store them inBox<Locale>andBox<SystemLocale>, which both can be stored in aBox<dyn Format>.Sadly,
Box<dyn Format>is unsized and therefore unsupported by this crate.As all the calls use
&Format(as a reference), this can be fixed by adding+ ?Sizedto all function calls, allowing unsized object references.This allows the following code to compile: