fix: std::memory_order::memory_order_relaxed -> std::memory_order_relaxed

[chenrui333]

seeing build failure as below while building hsd 7.0.0

  npm error ../deps/leveldb/util/env_posix.cc:817:34: error: no member named 'memory_order_relaxed' in 'std::memory_order'; did you mean 'std::memory_order_relaxed'?
  npm error   817 |     env_initialized_.store(true, std::memory_order::memory_order_relaxed);
  npm error       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  npm error       |                                  std::memory_order_relaxed
  npm error /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__atomic/memory_order.h:43:23: note: 'std::memory_order_relaxed' declared here
  npm error    43 | inline constexpr auto memory_order_relaxed = memory_order::relaxed;
  npm error       |                       ^
  npm error ../deps/leveldb/util/env_posix.cc:834:35: error: no member named 'memory_order_relaxed' in 'std::memory_order'; did you mean 'std::memory_order_relaxed'?
  npm error   834 |     assert(!env_initialized_.load(std::memory_order::memory_order_relaxed));
  npm error       |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  npm error       |                                   std::memory_order_relaxed
  npm error /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/assert.h:75:25: note: expanded from macro 'assert'
  npm error    75 |     (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)
  npm error       |                         ^
  npm error /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__atomic/memory_order.h:43:23: note: 'std::memory_order_relaxed' declared here
  npm error    43 | inline constexpr auto memory_order_relaxed = memory_order::relaxed;
  npm error       |                       ^
  npm error 2 errors generated.

This is due to std::memory_order::memory_order_relaxed is removed since C++ 20: https://en.cppreference.com/w/cpp/atomic/memory_order.

upstream has already patched as google/leveldb#965

relates to Homebrew/homebrew-core#200615

cc @nodech

[nodech]

Yeah, I saw this issue on nodejs v23 (that's when std version bump happens) and decided to not update until nodejs v24. I guess brew targets the v23 nodejs ?

Reason was to fully upgrade leveldb instead of patching this one for the next major version. But I think it makes sense to fix this. Thanks for the PR!

Do you want me to release hsd v7.0.1 ?

I will release bdb patch right away.

[chenrui333]

Yeah, I saw this issue on nodejs v23 (that's when std version bump happens) and decided to not update until nodejs v24. I guess brew targets the v23 nodejs ?

yes, we are targeting the latest node, which is nodejs23 at this point

Do you want me to release hsd v7.0.1 ?

that would be great, thanks!!

[chenrui333]

thanks for bsd new release, works fine for my hsd 7.0.0 release build now.