Skip to content

Conversation

@finnhughes
Copy link

avc1 can support multiple extensions including avcC and pasp
Not sure where this is documented in ISO standards, I found it in an mp4 file and then found it documented for quicktime https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html

avcC has optional fields at the end which are now ignored with GreedyBytes if present, without this tweak I had mp4 files I couldn't parse if they had any extra info after the pps.

I'm using the BytesIO so that I can assert the expected data was parsed.

Note this is a breaking change since avcC used to be stored in avc_data but is now stored in extensions[avcC]. In QT the order is not defined so I think the extensions list is the right way to handle it.

avc1 can support multiple extensions including avcC and pasp (found in QT documentation)

avcc has optional fields at the end which are now ignored with GreedyBytes if present
@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #6 into master will increase coverage by 1.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   83.11%   84.51%   +1.39%     
==========================================
  Files           3        3              
  Lines         154      155       +1     
==========================================
+ Hits          128      131       +3     
+ Misses         26       24       -2
Impacted Files Coverage Δ
src/pymp4/parser.py 84% <100%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f73f01...05d5134. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants