Fix bugs and drop support for Postgres >= 9.0 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`complex--0.5.0.sql` was ending up in the `DATA` variable, which causes newer versions of `make` to error out. So simplify the `Makefile` a bit by requiring Postgres 9.1 and removing the conditional code. Also remove references to installing the extension on earlier versions of Postgres. Requires Postgres 9.1 in `META.json` and fix the GitHub URLs. Add a second expected output for updated formatting on newer versions of Postgres (I tested with 16.2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complex--0.5.0.sqlwas ending up in theDATAvariable, which causes newer versions ofmaketo error out. So simplify theMakefilea bit by requiring Postgres 9.1 and removing the conditional code. Also remove references to installing the extension on earlier versions of Postgres.Requires Postgres 9.1 in
META.jsonand fix the GitHub URLs.Add a second expected output for updated formatting on newer versions of Postgres (I tested with 16.2).