Replaced wsock32.lib with Ws2_32.lib to be coherent, ensure using the same WinSock2 library #2314
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced some instances of wsock32.lib with Ws2_32.lib, so the code will be more coherent. I don't know if it makes any difference, but Ws2_32.lib should ensure that WinSock2 is used; else it might mix WinSock1 with WinSock2. There are some other externs to that probably should be marked with Ws2_32.lib instead of [CLink, CallingConvention(.Stdcall)] (native library?), to ensure usage of the same library. I have not changed it, because it appears to work right now.