Skip to content

Conversation

@Ivo-Balbaert
Copy link
Contributor

I am not 100% sure that the changes are what you want, I discuss them here a bit:

  1. https://www.beeflang.org/docs/language-guide/memory/
    Variant: link reflection doesn't work
    points to https://www.beeflang.org/docs/language-guide/memory/reflection.html
    but this gives: Page not found
    Link should probably be: https://www.beeflang.org/docs/language-guide/reflection/

  2. The original int newVal = GetMinusOne(i);
    gives a compilation error: ERROR: Unable to implicitly cast 'uint' to 'int'
    which is solved by changing int to uint

  3. https://www.beeflang.org/docs/language-guide/operators/
    /* Binary + operator */
    public static Vector2 operator+(Vector2 lhs, Vector2 rhs)
    {
    return .(lhs.x, rhs.y);
    }
    I don't understand how this could mean a + operation of 2 vectors.
    I would expect: return .(lhs.x + rhs.x, lhs.y + rhs.y);

  4. https://www.beeflang.org/docs/language-guide/typerefs/
    int intVal = (.)floatVal); <-- minor improvement adding int and ;

  5. https://www.beeflang.org/docs/corlib/
    this-party <-- probably here also third-party was meant.

Thanks for the review and keep up the brilliant work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant