speeding up the gallery, a bit #720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by serializing json off of the main thread
by prefetching gallery's thumbnails
theospears
reviewed
Jan 11, 2026
Collaborator
theospears
left a comment
theospears
left a comment
There was a problem hiding this comment.
I agree this is needed! Added a few questions, but also happy to merge as-is if you think this is the best approach.
| let goal = fetchedResultsController.object(at: indexPath) | ||
| return try? goal.thumbUrl.asURL() | ||
| } | ||
| let downloader = ImageDownloader.default |
Collaborator
There was a problem hiding this comment.
Currently GoalImageView has its own static ImageDownloader. Should we be either having this code use that downloader, or moving that to use the default one? I'm not sure if multiple instances share cache between them?
| case .success(let data): | ||
| let asJSON = try? JSONSerialization.jsonObject(with: data) | ||
| return asJSON | ||
| case .success(let data): return try await Task.detached { try JSONSerialization.jsonObject(with: data) }.value |
Collaborator
There was a problem hiding this comment.
What are your thoughts on this solution vs making RequestManager an actor so all its work is done on a background thread?
Contributor
Author
There was a problem hiding this comment.
Switching it over to actor seems like a more complete solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upon returning to the gallery, especially after bring the app back into the foreground, scrolling the gallery can be very choppy.
This PR reduces some of the lagginess by moving json serializing off of the main thread and by prefetching the gallery's thumbnails.
Validation
Used app in Simulator
#588 mentioned a slow gallery.