-
Notifications
You must be signed in to change notification settings - Fork 5
Add all bridges #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kubo6472
wants to merge
17
commits into
beeper:main
Choose a base branch
from
kubo6472:save
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add all bridges #13
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8ff3ff4
Update BridgeDeploy.tsx
kubo6472 cb4a488
force yarn v1 with corepack
kubo6472 859c228
Create dependabot.yml
kubo6472 d7791fe
Bump the npm_and_yarn group across 1 directory with 5 updates
dependabot[bot] 7122746
Merge pull request #1 from kubo6472/dependabot/npm_and_yarn/npm_and_y…
kubo6472 5f1b3fd
Bump nanoid in the npm_and_yarn group across 1 directory
dependabot[bot] 938843c
Update Welcome.tsx
kubo6472 da278c6
Merge pull request #2 from kubo6472/dependabot/npm_and_yarn/npm_and_y…
kubo6472 6ea8142
Bump the npm_and_yarn group across 1 directory with 2 updates
dependabot[bot] 519d041
Merge pull request #3 from kubo6472/dependabot/npm_and_yarn/npm_and_y…
kubo6472 c3022e0
Update BeeperLogin.tsx
kubo6472 6a5051a
Update FlyLogin.tsx
kubo6472 ffa48d2
Update FlyLogin.tsx
kubo6472 31c4074
Update route.ts
kubo6472 d3c7a1c
Update BridgeInstance.tsx
kubo6472 3163d32
Bump next in the npm_and_yarn group across 1 directory
dependabot[bot] d493906
Merge pull request #4 from kubo6472/dependabot/npm_and_yarn/npm_and_y…
kubo6472 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # To get started with Dependabot version updates, you'll need to specify which | ||
| # package ecosystems to update and where the package manifests are located. | ||
| # Please see the documentation for all configuration options: | ||
| # https://docs.github.com/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file | ||
|
|
||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "yarn" # See documentation for possible values | ||
| directory: "/" # Location of package manifests | ||
| schedule: | ||
| interval: "weekly" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redeploy logic needs improvements for robustness.
The redeploy implementation has several concerns:
Line 27: Always uses the first machine without validation - if multiple machines exist, is this intentional?
Line 38: The hardcoded image
"ghcr.io/beeper/bridge-manager"has no version tag::latestexplicitlyNo deployment verification: Unlike the main deploy flow (lines 182-200), the redeploy returns immediately without confirming the machine restarted or is running the new image
Line 37: Spreading
...machine.configcould be risky if the config schema has changed between bridge-manager versionsConsider these improvements:
// If redeploy flag is passed, update existing machine to latest image if (redeploy) { const res_list = await fetch(`https://api.machines.dev/v1/apps/${appName}/machines`, { method: 'GET', headers: { 'Authorization': `Bearer ${flyToken}`, 'Content-Type': 'application/json', } }) if (res_list.status !== 200) { const list_data = await res_list.json() return NextResponse.json({ error: JSON.stringify(list_data) }, { status: 500 }) } const machines = await res_list.json() if (!machines || machines.length === 0) { return NextResponse.json({ error: `No machines found for app ${appName}` }, { status: 404 }) } const machine = machines[0] const update_res = await fetch(`https://api.machines.dev/v1/apps/${appName}/machines/${machine.id}`, { method: 'POST', headers: { 'Authorization': `Bearer ${flyToken}`, 'Content-Type': 'application/json', }, body: JSON.stringify({ config: { ...machine.config, - image: "ghcr.io/beeper/bridge-manager" + image: "ghcr.io/beeper/bridge-manager:latest" } }) }) if (update_res.status !== 200) { const update_data = await update_res.json() return NextResponse.json({ error: JSON.stringify(update_data) }, { status: 500 }) } + + // TODO: Consider adding verification that the machine restarted successfully return NextResponse.json({ success: true }) }📝 Committable suggestion
🤖 Prompt for AI Agents