pass browserify-supplied this argument to transformFn in makeStringTrans...#10
Merged
jwalton merged 1 commit intobenbria:masterfrom May 7, 2015
cgc:pass-this-arg
Merged
pass browserify-supplied this argument to transformFn in makeStringTrans...#10jwalton merged 1 commit intobenbria:masterfrom cgc:pass-this-arg
jwalton merged 1 commit intobenbria:masterfrom
cgc:pass-this-arg
Conversation
Contributor
Author
There was a problem hiding this comment.
might make more sense to pass as in transformOptions?
Contributor
Author
|
ping @benbria |
Contributor
|
If I don't fix this tomorrow, harass me some more. :) |
jwalton
added a commit
that referenced
this pull request
May 7, 2015
pass browserify-supplied this argument to transformFn in makeStringTrans...
Contributor
|
Published as 1.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...form
I'd need functionality like this to make davidguttman/sassify#25 work. It likely makes sense to add tests?