globs with leading forward slash should match relative to project root #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doublerebel Thanks for the fix, I've merged it into my fork which also includes CoffeeScript 2.6.1 support here: https://github.com/DanielXMoore/CoffeeCoverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like when glob package was swapped out for minimatch, we accidentally lost the ability to match globs with a leading forward slash.
I'm first pushing the failing test to serve as example, then pushing the fix. I can squash these if needed.
Sidenote: my master branch is a working version of coffee-coverage for Iced CoffeeScript. It's almost perfect and backwards compatible, but will require upkeep so I haven't made a PR for it against the main package. This package is really useful, thanks!