Added support for event duration#20
Open
rmatejacabello wants to merge 9 commits intobenignware:masterfrom
Open
Added support for event duration#20rmatejacabello wants to merge 9 commits intobenignware:masterfrom
rmatejacabello wants to merge 9 commits intobenignware:masterfrom
Conversation
Author
|
There was a bug with different time zones to calculate the duration. Fixed now. |
Member
|
Many thanks for contributing a valuable feature. I'll try to get into it and merge into master as soon as possible. |
Bringing fork in line with updates
… 3.4 mise; fix keyword args/after_save symbol; IceCube rule count/until; nil-safety; tests green on Ruby 3.4.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a field "time_end" to support events duration.
Instead of creating a new migration file to include that field, I added it to the original migrations/create_schedules.rb