use first_name if username is undefined #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use first_name for fromUsername if username is undefined
houndci-bot
reviewed
Dec 23, 2016
|
|
||
| const type = keys.pop(); | ||
| const fromUsername = item.message.from.username; | ||
| const fromUsername = typeof(item.message.from.username) === 'undefined' ? item.message.from.first_name : item.message.from.username; |
There was a problem hiding this comment.
Line is too long.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Identifier 'first_name' is not in camel case.
Owner
|
@shrmnk This looks good to me |
Contributor
|
@benjick I just ran into this bug. Any chance on getting it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use first_name for fromUsername if username is undefined