Feature/add skybox processing #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2004a
force-pushed
the
master
branch
2 times, most recently
from
ec13490 to
b621d0c
Compare
splatDetailTex acts as a switch to turn on splat detailing, if its present in the mapinfo.lua file. It doesn't actually need to exist inside the .sd7 anywhere. Testing for its presence, therefore, and even throwing an error for its absence is unnecessary
burnhamrobertp
force-pushed
the
feature/add-skybox-processing
branch
from
bace3b3 to
fc0bfda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
parseSkyboxconfig option so as to not break backwards compatibility.This PR adds functionality for the skybox functionality of beyond-all-reason/maps-metadata#569
Per the AI disclosure policy:
These changes were tested on a macroscopic level, investigating the produced files against their source and the expected output. I also read through the code to ensure the approach looked appropriate, but while I'm knowledgeable in the area of mipmaps, image manipulation/transformation, and the underlying mathematics, its not my day job.