Skip to content

Conversation

@burnhamrobertp
Copy link
Contributor

@burnhamrobertp burnhamrobertp commented Feb 8, 2026

Adds husky and a pre-commit hook to run linting, minimizing needless CI errors

The husky || true in package.json is to ensure the CI/CD pipeline itself doesn't error if it doesn't install dev-dependencies

@p2004a
Copy link
Collaborator

p2004a commented Feb 8, 2026

I don't like forcing people to use pre-commit scripts, it needs to be opt in. I find husky also quite meh because it just set up symlinks and the commands are not verifying commit, they are verifying current state of repo regardless of what is staged vs not staged.

@burnhamrobertp
Copy link
Contributor Author

yeah, my typical approach for its integration into a repo is using it in combination with lint-staged but that doesn't address all of the points you raised. I figured I'd offer it in case it was useful to reduce build failures and raise the bar for pull requests before they're submitted and running into the CICD pipeline.

I will mention, though, that the build pipeline already forces developers to write code that meets that threshold. So regardless of whether or not, they are being forced to lint their code when they write it versus when they submit a pull request for it, the expectation is still the same. And if they choose to disable commit hooks, the enforcement is still there when the PR is submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants