Open
Conversation
This facilitates running on a site like github pages. Setting the config.BASENAME will propagate through App and ListPages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the project to easily run on GitHub Pages. This is particularly useful for forks which might make changes (adding their own roms) and wish to present that to the world.
Adds a single command
yarn run publishto push to gh-pages. I'm open to a different command asyarn publishis very different thing.Major motivation was the ability to fork the project, change the config to show my rom, and then push it to the world for use.
FIXES: #371
(NOTE: Resubmission of #373)
Though this can be merged separately, I'd love to see #372 merge first, and then to update this PR to merge on top of #372. I wasn't able to change the base across forks and could only target
masterso I broke them into 2 separate PRs each of which stands on its own.