Security updates, runner state sync + proxy concurrency fixes #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix refreshTargets to update isConfigured state when targets change - Auto-start runner when first target is added and runner is offline - Restructure SECURITY.md: lead with security policy, then architecture - Update README roadmap: remove completed items, add reactive state management 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Set restrictive umask (077) at app startup for user-only file access - Add ensureAppDataDir() to create ~/.localmost with 700 permissions - Validate GitHub URLs before opening in browser to prevent phishing - Remove unused attestation checking code from runner downloader 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The RUNNER_START IPC handler was missing critical initialization that the auto-start code in index.ts had: - Initialize broker proxy with target credentials - Start the broker proxy server - Send state machine START/INITIALIZED events - Update tray menu after start/stop Without these, jobs weren't being picked up and tray wasn't updated when starting the runner via IPC (e.g., after adding first target). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add webpack splitChunks to separate vendor code (React, FontAwesome) into separate bundles, reducing main.js from 251 KiB to 37.7 KiB - Use [name] pattern for CSS chunk filenames to avoid conflicts - Remove unused catch parameter in runner-manager.ts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bfulton
force-pushed
the
update-security
branch
from
3ebd4e9 to
f03b232
Compare
Two issues caused "Mixed (1/3 connected)": 1. TARGETS_ADD IPC handler didn't notify broker proxy about new targets 2. brokerProxyService.addTarget() didn't create sessions if already running Now: - TARGETS_ADD loads credentials and adds target to running broker proxy - TARGETS_REMOVE cleans up target from broker proxy - addTarget() creates session immediately if proxy is already running 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
runner-manager.ts used raw os.hostname() which includes .local on macOS, but ipc-handlers/app.ts getHostname() stripped it. This caused mismatch between config default (localmost.blue-243) and display name (localmost.blue-243.local.1-4). Added getCleanHostname() helper and use it consistently. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1. Runner display name now shows: - Single target: the proxy runner name (e.g., localmost.blue-243.owner-repo) - Multiple targets: prefix with wildcard (e.g., localmost.blue-243.*) 2. Runner name link now opens all registered runner settings pages, not just the first one. Shows tooltip indicating count when multiple. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bfulton
changed the title
- Register N runners per target (default 4) for parallel job execution - Store credentials in numbered subdirectories: proxies/<target-id>/1/, /2/, etc. - Update broker proxy to manage multiple sessions per target - Persist session IDs to disk for crash recovery - Clean up stale sessions on startup before creating new ones - Wait for session deletions on shutdown to prevent orphaned sessions - Add settings change logging 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refreshTargets()properly syncsisConfiguredstate and auto-starts the runner when the first target is added.Test plan
localmost statusmatches UI state🤖 Generated with Claude Code