-
-
Notifications
You must be signed in to change notification settings - Fork 68
update fluttertoast and connectivity_plus #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @arifikhsan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates fluttertoast and connectivity_plus to new major versions and adds related iOS/macOS configuration. My main concern, which is critical, is that these dependency updates introduce breaking changes, but the necessary code migrations are missing. This will break the package. I've also left a few medium-severity suggestions to improve the iOS and macOS Podfile configurations for better maintainability and consistency.
| fluttertoast: ^9.0.0 | ||
| connectivity_plus: ^7.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependency upgrades are major version bumps (fluttertoast from v8 to v9, connectivity_plus from v6 to v7), which introduce significant breaking changes. The pull request lacks the necessary code changes to accommodate these new versions. This will break the library. Please update the Dart code to align with the new APIs of these packages.
Breaking changes in connectivity_plus: ^7.0.0:
Connectivity().checkConnectivity()now returns aList<ConnectivityResult>.onConnectivityChangedstream now emits aList<ConnectivityResult>.
Breaking changes in fluttertoast: ^9.0.0:
toastLengthnow uses theToastenum.gravitynow uses theToastGravityenum.backgroundColorandtextColorare deprecated in favor of other styling methods.
| @@ -0,0 +1,43 @@ | |||
| # Uncomment this line to define a global platform for your project | |||
| # platform :ios, '13.0' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended to uncomment this line and set an explicit iOS deployment target. This improves build reproducibility and stability by not relying on a CocoaPods default version that could change over time. The suggested '13.0' is a reasonable choice, though you might want to align it with the minimum version your package supports.
platform :ios, '13.0'
| generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'ephemeral', 'Flutter-Generated.xcconfig'), __FILE__) | ||
| unless File.exist?(generated_xcode_build_settings_path) | ||
| raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure \"flutter pub get\" is executed first" | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message contains an escaped double-quoted command \"flutter pub get\". For consistency with the iOS Podfile and for better readability, it's better to remove the quotes or use single quotes.
raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first"
| matches = line.match(/FLUTTER_ROOT\=(.*)/) | ||
| return matches[1].strip if matches | ||
| end | ||
| raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Flutter-Generated.xcconfig, then run \"flutter pub get\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message contains an escaped double-quoted command \"flutter pub get\". For consistency with the iOS Podfile and for better readability, it's better to remove the quotes or use single quotes.
raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Flutter-Generated.xcconfig, then run flutter pub get"
No description provided.