This repository was archived by the owner on Mar 13, 2024. It is now read-only.
Feature/timeline #136
Open
Feature/timeline #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent drag functionality.
jaymcp
reviewed
Feb 13, 2019
Contributor
jaymcp
left a comment
jaymcp
left a comment
There was a problem hiding this comment.
This works really nicely; great work!
One thing, though, is that the front-end breaks if JavaScript is disabled/not available. I'd suggest adjusting the layout in CSS with a sensible fallback if the .no-js class is present.
Contributor
Author
|
If there's no js the timeline milestones will be stacked so that they are all visible at once due to scroll functionality being disabled when js is disabled. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Resolves #128