Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

Resolve Travis CI build issues && add PHP 7.4, 8.0 #167

Open
jaymcp wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Resolve Travis CI build issues && add PHP 7.4, 8.0 #167

jaymcp wants to merge 10 commits into from

Conversation

@jaymcp
Copy link
Contributor

@jaymcp jaymcp commented Jul 7, 2022

Proposed Changes

  • Add PHP 7.4 && 8.0 to Travis CI build matrix
  • Downgrade Composer to v1 in Travis CI
  • Bump Travis CI node version to 12
  • Bump Travis CI PHPCS ruleset versions
  • Resolve PHPCS errors thrown by updating PHPCS ruleset versions

@jaymcp jaymcp requested a review from ampersarnie July 7, 2022 08:56
ampersarnie
ampersarnie approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@ampersarnie ampersarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ampersarnie
ampersarnie approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@ampersarnie ampersarnie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This popped up in my notifications to review again, and seem to have gotten ahead of myself.)

@jaymcp
Copy link
Contributor Author

jaymcp commented Jul 15, 2022

yeah sorry mate. appreciate it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ampersarnie ampersarnie ampersarnie approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaymcp @ampersarnie