Adds support for fetching BigCommerce Products by SKU. Including via shortcode#266
Open
emiliorcueto wants to merge 1 commit intobigcommerce:masterfrom
Open
Adds support for fetching BigCommerce Products by SKU. Including via shortcode#266emiliorcueto wants to merge 1 commit intobigcommerce:masterfrom
emiliorcueto wants to merge 1 commit intobigcommerce:masterfrom
Conversation
Collaborator
|
This PR currently needs a refresh along with consideration whether still an issue. As we were triaging the repo this month, my recommendation would be to either refresh and get into the next release or to close out. If it is due to get in then I would recommend having an issue to link with it which unless I am mistaken I don't see. cc @chanceaclark and @bc-erich |
Collaborator
|
I am struggling to recreate this. I think this could be myself or it might be that this isn't an issue anymore. My thinking however is we need to have a few more things on this PR to ensure testing can be done and also get a refresh. |
Contributor
|
Agreed. @emiliorcueto would you mind providing a little more info here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for fetching BigCommerce Products by SKU.
by_product_skuandqueryto theBigCommerce\Post_Types\Productclassskuto theProduct_Componentsclass implementing thebc-componentshortcodeDocumentation
Historically, one would only be able to fetch a product with a BigCommerce Product ID
E.g.
$product = \BigCommerce\Post_Types\Product\Product::by_product_id( $product_id );This pull request adds the ability to fetch of a product in a very similar fashion by BigCommerce Product SKU
E.g.
$product = \BigCommerce\Post_Types\Product\Product::by_product_sku( $product_sku );Additionally, the
bc-componentshortcode attributes have been updated to support fetching by BigCommerce Product SKU as well.E.g.
echo do_shortcode('[bc-component sku="' . $product_sku . '" type="add_to_cart"]');