fix(core): show success message when a subscribed user resubscribes #2795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Type |
|---|---|
| @bigcommerce/catalyst-core | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jorgemoya
force-pushed
the
catalyst-1660-update-message-already-subscribed
branch
from
0f69c38 to
b133a9c
Compare
jorgemoya
force-pushed
the
catalyst-1660-update-message-already-subscribed
branch
from
598a1eb to
863f23b
Compare
jorgemoya
deleted the
catalyst-1660-update-message-already-subscribed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Show same success message when a user subscribes for the first time, or is already subscribed.
Testing
Locally
Migration
Update
core/components/subscribe/_actions/subscribe.tsaction to include new logic for resubscribed use case.