Grafi 55/add mcp function tool #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements an MCP-based function tool (MCPFunctionTool) that invokes MCP (Model Context Protocol) as a standalone function with inputs obtained by deserializing message content. The implementation extends the existing FunctionTool base class and adds support for async generators.
Key Changes
- Added MCPFunctionTool class that wraps MCP client calls as function tools
- Enhanced FunctionTool base class to support async generator functions
- Added comprehensive unit and integration tests for the new functionality
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| grafi/tools/functions/impl/mcp_function_tool.py | New MCPFunctionTool implementation with MCP client integration, builder pattern, and serialization support |
| grafi/tools/functions/function_tool.py | Added async generator support and TypeVar for generic builder pattern |
| tests/tools/functions/test_mcp_function_tool.py | Comprehensive unit tests for MCPFunctionTool initialization, invocation, and serialization |
| tests/tools/functions/test_function_tool.py | Expanded FunctionTool tests to cover async functions, various output types, and error handling |
| tests_integration/mcp_assistant/mcp_function_tool_local.py | Integration tests demonstrating MCPFunctionTool usage with direct invocation, assistants, and serialization |
| tests_integration/mcp_assistant/mcp_deserialize_assistant_example_local.py | Integration test for deserializing and invoking assistants using MCP tools |
| grafi/tools/function_calls/impl/mcp_tool.py | Updated docstring to be more generic |
| CLAUDE.md | Restructured and streamlined documentation for better clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ayomaska18
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mplement an MCP-based function tool.
MCP must be invoked as a standalone function, with inputs obtained by deserializing the incoming message content.