ListResult tree traversal bugfix #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue during tree traversal, where more than 3 tokens are returned from splitting some taxonstr, specifically when the name contains additional "[" and "]" brackets. For example in
(When using the NCBI Taxonomy database)
The fix is as fast as, or faster than the original code splitting method (tested on 1,000,000 randomly generated sequences), with slightly faster outcomes on longer name strings.
steps to reproduce bug:
results in exception: