Mutations and Features use the same zero-based interval.#4
Open
the-code-magician wants to merge 12 commits intomasterfrom
Open
Mutations and Features use the same zero-based interval.#4the-code-magician wants to merge 12 commits intomasterfrom
the-code-magician wants to merge 12 commits intomasterfrom
Conversation
All tests passing.
co/component.py
Outdated
Contributor
There was a problem hiding this comment.
Also, move the logic from feature._move in here. Or you can make it a class method on Feature, but then you don't need this function here.
co/component.py
Outdated
Contributor
There was a problem hiding this comment.
I see what the issue is here, but this is probably the wrong approach. We should refactor the code so that changed features are tracked separately and then at the end there is one step where the features are transformed. (transform? great name.)
Conflicts: co/component.py
Conflicts: co/component.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests passing.