Skip to content

Cache format regex for tiny performance boost #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lejeunerenard wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cache format regex for tiny performance boost #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jspack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ function JSPack() {
};

// Class data
m._sPattern = '(\\d + )?([AxcbBhHsfdiIlLqQ])';
m._sPattern = new RegExp('(\\d + )?([AxcbBhHsfdiIlLqQ])', 'g');
m._lenLut = {'A': 1, 'x': 1, 'c': 1, 'b': 1, 'B': 1, 'h': 2, 'H': 2, 's': 1,
'f': 4, 'd': 8, 'i': 4, 'I': 4, 'l': 4, 'L': 4, 'q': 8, 'Q': 8
};
Expand Down Expand Up @@ -202,7 +202,7 @@ function JSPack() {
bBE = (fmt.charAt(0) != '<');

p = p ? p : 0;
var re = new RegExp(this._sPattern, 'g');
var re = this._sPattern;
var m, n, s;
var rv = [];
while (m = re.exec(fmt)) {
Expand Down Expand Up @@ -234,7 +234,7 @@ function JSPack() {
// Set the private bBE flag based on the format string - assume big-endianness
bBE = (fmt.charAt(0) != '<');

var re = new RegExp(this._sPattern, 'g');
var re = this._sPattern;
var m, n, s, j;
var i = 0;
while (m = re.exec(fmt)) {
Expand Down Expand Up @@ -272,7 +272,7 @@ function JSPack() {

// Determine the number of bytes represented by the format string
m.CalcLength = function (fmt) {
var re = new RegExp(this._sPattern, 'g');
var re = this._sPattern;
var sum = 0;
var m;
while (m = re.exec(fmt)) {
Expand Down