refactor: Refactor GetSize implementation by modularizing code #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparate files - Moved ownership-related implementations of GetSize to `ownership.rs` - Moved primitive type implementations of GetSize to `primitives.rs` - Moved range-related implementations of GetSize to `ranges.rs` - Moved standard type implementations of GetSize to `std_types.rs` - Moved synchronization-related implementations of GetSize to `sync_impls.rs` - Cleaned up the main library file `lib.rs` to improve readability and organization
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
bircni
force-pushed
the
refactoring
branch
2 times, most recently
from
b94a244 to
d9af721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ownership.rsprimitives.rsranges.rsstd_types.rssync_impls.rslib.rsto improve readability and organization