Bump faraday, faraday_middleware and Bitbucket API versions#98
Open
sarmad90 wants to merge 7 commits intobitbucket-rest-api:masterfrom
Open
Bump faraday, faraday_middleware and Bitbucket API versions#98sarmad90 wants to merge 7 commits intobitbucket-rest-api:masterfrom
sarmad90 wants to merge 7 commits intobitbucket-rest-api:masterfrom
Conversation
sarmad90
changed the title
sarmad90
changed the title
The use of `Hashie::Mash` in `Response::Mashify` creates a lot of warnings
per response in the logs that aren't really valuable, and similar projects ignore
them as well.
`Hashie::Mash.quiet` is a built-in class method that creates an anonymous
class to silence the warnings it creates.
```ruby
irb> Hashie::Mash.new({"size" => "foo"})
You are setting a key that conflicts with a built-in method Hashie::Mash#size defined in Hash. This can cause unexpected behavior when accessing the key as a property. You can still access the key via the #[] method.
#=> {"size"=>"foo"}
irb> Hashie::Mash.quiet.new({"size" => "foo"})
#=> {"size"=>"foo"}
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make this gem compatible with other gems depending on newer versions of faraday.
I've fixed some endpoints and added support for some new endpoints. This is working fine within the context of my project. I understand that there maybe some issues with some other APIs. I didn't have enough time to test and fix everything. Let me know if someone would like to co-author this PR.
I was also facing APIs depreciation error. Which I later fixed by changing the APIs version from 1.0 to 2.0. It's working fine for my cases so far. But feel free to point out any errors or contribute to this PR.