Skip to content

Bugfix certificate and URL Output issue #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeoDiazL merged 9 commits into from
Jan 5, 2026
Merged

Bugfix certificate and URL Output issue #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cfab2eb
Null-trying
LeoDiazL Dec 29, 2025
3dc9d80
Fixing outputs
LeoDiazL Dec 30, 2025
195151e
Fix vm_url_first_nonempty
LeoDiazL Dec 30, 2025
e4c41e3
Fixing vm_url conditional
LeoDiazL Dec 30, 2025
92107c9
Go back
LeoDiazL Dec 30, 2025
5d39268
Back 2
LeoDiazL Dec 30, 2025
4eb277e
Test #2
LeoDiazL Dec 30, 2025
eacd5cd
Rollback aws_acm_certificates each.value
LeoDiazL Jan 5, 2026
13c2ad7
Format fix
LeoDiazL Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions operations/deployment/terraform/aws/bitovi_main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,13 +820,18 @@ locals {
alb_url = try(module.aws_lb[0].aws_alb_dns_name, null) != null ? "${local.protocol}${module.aws_lb[0].aws_alb_dns_name}" : null

vm_url_candidates = [
try(module.aws_route53[0].vm_url, null),
local.alb_url,
local.elb_url,
local.ec2_endpoint
try(try(module.aws_route53[0].vm_url, null),
local.alb_url,
local.elb_url,
local.ec2_endpoint, null)
]
vm_url_first_nonempty = [for url in local.vm_url_candidates : url if url != null && url != ""][0]
vm_url_first_nonempty = (
length([for url in local.vm_url_candidates : url if url != null && url != ""]) > 0
? [for url in local.vm_url_candidates : url if url != null && url != ""][0]
: null
)
}

# VPC
output "aws_vpc_id" {
value = module.vpc.aws_selected_vpc_id
Expand Down Expand Up @@ -883,7 +888,8 @@ output "application_public_dns" {
}

output "vm_url" {
value = local.vm_url_first_nonempty
description = "Will print the best available URL for the VM, ALB, ELB or EC2 instance"
value = try(local.vm_url_first_nonempty, null)
}

# EFS
Expand Down
2 changes: 1 addition & 1 deletion operations/deployment/terraform/modules/aws/certificates/aws_certificates.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data "aws_acm_certificate" "issued" {
"wildcard" = "*.${var.aws_r53_domain_name}",
"sub" = "${var.aws_r53_sub_domain_name}.${var.aws_r53_domain_name}"
} : {}
domain = each.value
domain = var.aws_r53_domain_name
}

# This block will create and validate the root domain and www cert
Expand Down