Bitcore vault #4039
Open
Bitcore vault #4039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahMaphet
reviewed
Nov 8, 2025
leolambo
reviewed
Dec 15, 2025
| * Override signTx to require vault access | ||
| */ | ||
| public async signTx(params: any): Promise<any> { | ||
| return this.withVaultAccess(params.passphrase, super.signTx.bind(this), params); |
Contributor
There was a problem hiding this comment.
this one is interesting withVaultAccess unlocks using the passphrase. but the passphrase still needs to be sent via params?
Contributor
Author
There was a problem hiding this comment.
Good catch. Updated.
| } | ||
|
|
||
| private getPublicKey(): string { | ||
| return this.publicKey.export({ type: 'spki', format: 'pem' }).toString(); |
Contributor
There was a problem hiding this comment.
add this.publicKey null check
| if (!walletEntry) { | ||
| throw new Error(`Wallet not found: ${name}`); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
consider privateKey null check
if (!this.privateKey) {
throw new Error('Private key not available - secure process not initialized or already cleaned up');
}
| }); | ||
|
|
||
| await this.sendMessage<void>('initialize', {}); | ||
| const publicKeyPem = await this.sendMessage<string>('getPublicKey', {}); |
Contributor
There was a problem hiding this comment.
consider validating retrieved key
if (!publicKeyPem || typeof publicKeyPem !== 'string' || publicKeyPem.trim().length === 0) {
throw new Error('Invalid public key received from secure process');
}
Contributor
Author
There was a problem hiding this comment.
Good call. typeof publicKeyPem !== 'string' || !publicKey.trim().length is functionally similar - any other falsy value (including undefined) than "" wouldn't make it past the type check, and the trim().length takes care of "".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.