Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Dec 17, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29893

📔 Objective

Removes specific usage documentation for bitwarden-core crate. This will be included in the bitwarden-core crate with bitwarden/sdk-internal#618.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cloudflare-workers-and-pages
Copy link

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e8757e
Status: ✅  Deploy successful!
Preview URL: https://3d92d914.contributing-docs.pages.dev
Branch Preview URL: https://remove-bitwarden-core-docs.contributing-docs.pages.dev

View logs

@trmartin4 trmartin4 changed the title Remove bitwarden-core docs to move to crate. Remove bitwarden-core docs to move to crate Dec 17, 2025
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsed16a01b-688e-47c3-8161-8e2fef3c0c79

Great job! No new security vulnerabilities introduced in this pull request

@trmartin4 trmartin4 marked this pull request as ready for review December 17, 2025 14:28
@trmartin4 trmartin4 requested a review from a team as a code owner December 17, 2025 14:28
@claude
Copy link

claude bot commented Dec 17, 2025

Claude finished @trmartin4's task in 1m 29s —— View job


Pull Request Review

Review complete - no issues found.

  • Code review complete

@withinfocus withinfocus changed the title Remove bitwarden-core docs to move to crate Remove bitwarden-core docs given move to crate Dec 17, 2025
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The less detail here the better -- keep this close to code.

@trmartin4 trmartin4 merged commit af1b7df into main Dec 17, 2025
19 checks passed
@trmartin4 trmartin4 deleted the remove-bitwarden-core-docs branch December 17, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants