Update Event Logging to reflect current event integrations implementation #734
+94
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Claude finished @brant-livefront's task in 2m 29s —— View job Code Review CompleteThe review has been completed. I found issues that need to be addressed: Critical Issues
Style Issues
The PR successfully restructures the documentation to reflect the current production implementation with Azure Service Bus, and addresses the previous review feedback from withinfocus. |
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Deploying contributing-docs with
|
| Latest commit: |
dc370e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56d90ce9.contributing-docs.pages.dev |
| Branch Preview URL: | https://brant-update-event-logging-s.contributing-docs.pages.dev |
withinfocus
requested changes
Dec 17, 2025
|
|
||
| The cloud instance of Bitwarden has migrated to using the Azure Service Bus implementation of | ||
| distributed events. However, there is still an option to use Azure Queue and Table Storage to handle | ||
| events. Here's how this works: |
Contributor
There was a problem hiding this comment.
🎨 None of the other sections have this, and it's arguably better for close-to-code docs over in the README -- move this over there and ensure such a thing exists for each offering. I don't think it should be here though as these docs are for setup, not explanation.
withinfocus
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Objective
Now that the event integrations implementation is live in Production, the Event Logging section of the contributing docs was out of date (it still had Azure Queue as the Prod implementation). This PR restructures the page to present how events are generated and then offer all three options as to how they are processed (Distributed events, Azure Queue or Database storage).
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes