-
Notifications
You must be signed in to change notification settings - Fork 24
[PM-27231] Account registration v2 for key connector #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4394208
73c08d8
a7dc33a
776c149
27a3e16
b48b698
d1fa6e8
9f5c26b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,8 +76,10 @@ rustls = { version = "0.23.19", default-features = false } | |
| rustls-platform-verifier = "0.6.0" | ||
|
|
||
| [dev-dependencies] | ||
| rand_chacha = "0.3.1" | ||
| mockall = { version = ">=0.13.1, <0.15" } | ||
| rand_chacha = ">=0.3.1, <0.4.0" | ||
| tokio = { workspace = true, features = ["rt"] } | ||
| wiremock = { workspace = true } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We generally do not use wiremock any longer and instead use the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I need to mock key connector api client (
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Argh, that's annoying. It's probably useful to extract that to it's own crate though? We're trying to trim down |
||
| zeroize = { version = ">=1.7.0, <2.0", features = ["derive", "aarch64"] } | ||
|
|
||
| [lints] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relaying feedback I got on my PR here, we probably want unit tests on this. Vault has some examples for this, but it generally involves moving the impl into a separate function that you pass in the "api client" dependency and other parameters to, then the test can replace that with a mocked api client.