Skip to content

Conversation

@bw-ghapp
Copy link
Contributor

@bw-ghapp bw-ghapp bot commented Dec 18, 2025

Updates the API bindings to d03277323fb9957c3d8cc5ae2d17f07efc9ad0f3

@bw-ghapp bw-ghapp bot requested a review from a team as a code owner December 18, 2025 12:03
@bw-ghapp bw-ghapp bot requested a review from dani-garcia December 18, 2025 12:03
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Logo
Checkmarx One – Scan Summary & Details6035e87b-be20-4e0d-bcbb-511df1da186d

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: sdlc/api-update (17aed67)
Completed: 2025-12-18 12:34:26 UTC
Total Time: 215s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.54%. Comparing base (2b6aae0) to head (17aed67).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   78.54%   78.54%           
=======================================
  Files         283      283           
  Lines       29251    29251           
=======================================
  Hits        22975    22975           
  Misses       6276     6276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten
Copy link
Contributor

quexten commented Dec 18, 2025

I've synced main into this to show the correct diff on #596

@claude
Copy link

claude bot commented Dec 18, 2025

Claude finished @bw-ghapp[bot]'s task in 2m 11s —— View job


Code Review Complete

The bitwarden-code-reviewer agent has finished analyzing this PR and posted its findings.

  • Review changes to API models
  • Review removal of phishing domains API
  • Review new identity models
  • Provide feedback

@claude
Copy link

claude bot commented Dec 18, 2025

Overall Assessment: APPROVE

Reviewed automated API binding update from server commit d03277323fb9957c3d8cc5ae2d17f07efc9ad0f3. All changes follow auto-generated code patterns with proper serialization attributes and consistent model definitions across both bitwarden-api-api and bitwarden-api-identity crates.

@dani-garcia dani-garcia merged commit 0a9599e into main Dec 18, 2025
61 of 62 checks passed
@dani-garcia dani-garcia deleted the sdlc/api-update branch December 18, 2025 12:43
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants