Skip to content

Check for http status code for health-check APIs #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akashnagesh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check for http status code for health-check APIs #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hubclient/health-check-client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ package hubclient

import (
"encoding/json"
"net/http"

"github.com/blackducksoftware/hub-client-go/hubapi"
"github.com/pkg/errors"
log "github.com/sirupsen/logrus"
Expand All @@ -39,6 +41,10 @@ func checkHealthStatus(c *Client, url string) (error, *hubapi.HealthCheckStatus)
return err, nil
}

if resp != nil && resp.StatusCode != http.StatusOK {
Copy link
Contributor

@tandr tandr Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the check for nil be done earlier? Is it possible to have no error AND no response?

return HubClientStatusCodeErrorf(resp.StatusCode, "got a %d response instead of a %d", resp.StatusCode, http.StatusOK), nil
}

if resp != nil {
if err := json.NewDecoder(resp.Body).Decode(&status); err == nil {
return nil, &status
Expand Down