fixes to loading config file and a few other little things #1
Conversation
There was a problem hiding this comment.
we shouldn't have a default config - there's no reason the user would have this file and we want to throw an error if they don't provide a config file
lib/assemblotron.rb
Outdated
There was a problem hiding this comment.
Use 2 (not 0) spaces for indentation.
Conflicts: bin/atron lib/assemblotron.rb test/test_soap_denovo_trans.rb
There was a problem hiding this comment.
Space missing after comma.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Conflicts: bin/atron lib/assemblotron.rb
There was a problem hiding this comment.
Space missing after comma.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
lib/assemblotron.rb
Outdated
There was a problem hiding this comment.
Surrounding space missing for operator '+'.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
There was a problem hiding this comment.
Why did you add basename? The whole point of using which is to get the full path to the executable, because backticks are unstable in whether they use the same shell as the one you're in (and therefore might have a different PATH).
There was a problem hiding this comment.
This is exactly what the previous code did.
See Hash#merge docs:
h1 = { "a" => 100, "b" => 200 }
h2 = { "b" => 254, "c" => 300 }
h1.merge(h2) #=> {"a"=>100, "b"=>254, "c"=>300}
|
is this redundant now @cboursnell ? it's very old |
3 participants
No description provided.