Make import Server in nut.py conditional#364
Open
ii0606226 wants to merge 1 commit intoblawar:masterfrom
Open
Conversation
Move `import Server` into `if args.server:` code block so it doesn't get imported when it's not used (i.e. on `python nut.py --decompress <filename>`) and doesn't throw an exception on pycurl-less systems (i.e. Windows as per `requirements.txt`, line 20). Minimal testing done: before change `--decompress` throws an exception; after change `--decompress` works, `-S` throws an exception.
|
for pycurl on windows use the prebuilt wheel - https://github.com/blawar/nut/blob/master/tests/pycurl-7.43.0.5-cp39-cp39-win_amd64.whl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
import Serverintoif args.server:code block so it doesn't get imported when it's not used (i.e. onpython nut.py --decompress <filename>) and doesn't throw an exception on pycurl-less systems (i.e. Windows as perrequirements.txt, line 20).Minimal testing done:
before change
--decompressthrows an exception;after change
--decompressworks,-Sthrows an exception.