[BUG] Added a click event to the generated button… #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he OL list when an item is clicked. Minor other changes, like switching all 'var's to, the ES6 standard, 'let'
… embedded the search option in the button.
…nd jQuery. [TASK] Added a bit more to the README.md file.
…slighty better UX. [ADD] Added onPostSelect callback option. [REFACTOR] Moved label margin to CSS file.
blazeworx
requested changes
May 29, 2019
Owner
blazeworx
left a comment
blazeworx
left a comment
There was a problem hiding this comment.
Hello, thank you for your contribution! Can you please resubmit this PR to the newly created develop branch?
Author
|
Hi, I don't mind making a pull request, but I've taken my fork way beyond a single PR, at this point. We had specific needs in our project, so it's pretty much tailored to that - you might not want it all merged in. Let me know if you're still interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and a toggle() on the OL list when an item is clicked. Minor other changes, like switching all 'var's to, the ES6 standard, 'let' is also added.
For some reason there was no events registered to the generated button - at first I thought i might be an issue with versions of jQuery (the demo site is using jQuery v1.11.2, and I'm on v3.2.1), but looking at the source, there was no events registered. Unless there's an inconsistency from the source to the minified source, it's beyond me how this actually work on the demo site...