Adds better support for mget and mset, linting and tests.#11
Open
ppsreejith wants to merge 21 commits intoblindsey:masterfrom
Open
Adds better support for mget and mset, linting and tests.#11ppsreejith wants to merge 21 commits intoblindsey:masterfrom
ppsreejith wants to merge 21 commits intoblindsey:masterfrom
Conversation
Keys command support added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mgetcommand now parses the keys and sends multiplemgetcommands to multiple redis nodes according to the hash ring. Similarly, themsetcommand goes through the keys and sends multiple mset commands to the required redis nodes. I also added a simple test file to run tests against mget and mset (and possible more) and added linting support (probably unnecessary 😅).