Shell scripts compatibility issue and icon for ted2_macos.app#477
Open
D-a-n-i-l-o wants to merge 3 commits intoblitz-research:developfrom
D-a-n-i-l-o:develop
Open
Shell scripts compatibility issue and icon for ted2_macos.app#477D-a-n-i-l-o wants to merge 3 commits intoblitz-research:developfrom D-a-n-i-l-o:develop
D-a-n-i-l-o wants to merge 3 commits intoblitz-research:developfrom
D-a-n-i-l-o:develop
Conversation
…o the icon appears in the macOS dock. Delete bin/ted2_macos.app and run rebuildted2go.sh to apply.
…test compatibility with different shells. For example Ubuntu uses 'dash' instead of 'bash' by default and some shells do not know the newer 'source' command, resulting in a script error at the 'source' command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS only: Added info.plist and Monkey2logo.icns to Ted2go.app, so the icon appears in the macOS dock. Delete bin/ted2_macos.app and run rebuildted2go.sh to apply.
Changed all "source common.sh" in scripts to ". ./common.sh" for greatest compatibility with different shells. For example Ubuntu uses 'dash' instead of 'bash' by default and some shells do not know the newer 'source' command, resulting in a script error at the 'source' command.