Skip to content

Conversation

@SuperJMN
Copy link
Collaborator

@SuperJMN SuperJMN commented Dec 22, 2025

Create Project View and styles.

  • Includes all the views
  • Pending views:
    • Stages
    • Wizard navigation bar

public string Symbol { get; } = symbol;

public static AmountUI FromBtc(int btc) => new(btc * 100_000_000);
public static AmountUI FromBtc(decimal btc) => new((long)(btc * 100_000_000));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this is correct? decimal normally means it is in sats format

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's correct! The FromBtc factory methods take BTC as input and convert to sats (internal representation). I went with decimal to avoid floating-point precision issues when dealing with fractional BTC values.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably won't have such a use case, if we do maybe we should not allow it.
Basically eiher sats or btc is what I suggest.

@SuperJMN SuperJMN force-pushed the improvements/create-project-v2 branch from 3c88b10 to 78fc1c5 Compare December 23, 2025 00:00
@SuperJMN SuperJMN marked this pull request as ready for review December 23, 2025 00:07
Copy link
Member

@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me you can fix the comments (if needed) in future prs

.NextCommand<Unit, ProjectTypeViewModel, String>(_ => StartSubwizard())
.WithCompletionFinalStep();

return createWizardResult.Map(wizard => rootWizard.Navigate(navigator));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this code exactly but it is ok lol (ui magic)

.Latest(new LatestProjects.LatestProjectsRequest())
.Map(response => response.Projects)
.TraverseSequentially(dto => projectAppService.GetProjectStatistics(dto.Id)
.MapSequentially(dto => projectAppService.GetProjectStatistics(dto.Id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this suppose to load the statistics later (because it seems to still depend on the stats being loaded) before rendering the list of projects

@dangershony dangershony merged commit 290ca3d into block-core:main Dec 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants