-
Notifications
You must be signed in to change notification settings - Fork 39
Add visuals for Create Project v2 #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visuals for Create Project v2 #607
Conversation
| public string Symbol { get; } = symbol; | ||
|
|
||
| public static AmountUI FromBtc(int btc) => new(btc * 100_000_000); | ||
| public static AmountUI FromBtc(decimal btc) => new((long)(btc * 100_000_000)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this is correct? decimal normally means it is in sats format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's correct! The FromBtc factory methods take BTC as input and convert to sats (internal representation). I went with decimal to avoid floating-point precision issues when dealing with fractional BTC values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably won't have such a use case, if we do maybe we should not allow it.
Basically eiher sats or btc is what I suggest.
3c88b10 to
78fc1c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok to me you can fix the comments (if needed) in future prs
| .NextCommand<Unit, ProjectTypeViewModel, String>(_ => StartSubwizard()) | ||
| .WithCompletionFinalStep(); | ||
|
|
||
| return createWizardResult.Map(wizard => rootWizard.Navigate(navigator)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this code exactly but it is ok lol (ui magic)
| .Latest(new LatestProjects.LatestProjectsRequest()) | ||
| .Map(response => response.Projects) | ||
| .TraverseSequentially(dto => projectAppService.GetProjectStatistics(dto.Id) | ||
| .MapSequentially(dto => projectAppService.GetProjectStatistics(dto.Id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this suppose to load the statistics later (because it seems to still depend on the stats being loaded) before rendering the list of projects
Create Project View and styles.