CI: Make apidocs push failures an error#985
Draft
pniedzielski wants to merge 1 commit intobloomberg:mainfrom
Draft
CI: Make apidocs push failures an error#985pniedzielski wants to merge 1 commit intobloomberg:mainfrom
pniedzielski wants to merge 1 commit intobloomberg:mainfrom
Conversation
Our API documentation CI workflow has been failing since September due to an unintended change in the `gh-pages` branch protection settings. We didn’t catch this, because the API documentation CI workflow is configured to invariably pass, even if any command fails. This change was made in commit 844ba5c as part of a fix for adding untracked generated documentation, but that fix was overzealous. This patch makes any failure to push to `gh-pages` a CI error. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
force-pushed
the
ci/apidocs-push-failure
branch
from
1cd00d0 to
83dc1f9
Compare
Collaborator
Author
|
This issue with |
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our API documentation CI workflow has been failing since September due to an unintended change in the
gh-pagesbranch protection settings. We didn’t catch this, because the API documentation CI workflow is configured to invariably pass, even if any command fails. This change was made in commit 844ba5c as part of a fix for adding untracked generated documentation, but that fix was overzealous.This PR makes any failure to push to
gh-pagesa CI error.