MBP List - MVP plus three stretch goals completed @dillon-mce#20
Open
vijaydas wants to merge 5 commits intobloominstituteoftechnology:masterfrom
vijaydas:master
Open
MBP List - MVP plus three stretch goals completed @dillon-mce#20vijaydas wants to merge 5 commits intobloominstituteoftechnology:masterfrom vijaydas:master
vijaydas wants to merge 5 commits intobloominstituteoftechnology:masterfrom
vijaydas:master
Conversation
|
Your code looks great Vijay! You've got all the required features and stretch goals. You're committing at meaningful times and with good commit messages, keep that up. And your code is nice and clean. My only suggestion would be to maybe add a few comments in your viewController and/or your model. Imagine you had never seen the code before, or that it had been six months since you last looked at it. What comments would help you quick grasp what is going on? |
Author
|
Thank you for the feedback Dillon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.