List Project#22
Open
sameeraleola wants to merge 2 commits intobloominstituteoftechnology:masterfrom
sameeraleola:master
Open
List Project#22sameeraleola wants to merge 2 commits intobloominstituteoftechnology:masterfrom sameeraleola:master
sameeraleola wants to merge 2 commits intobloominstituteoftechnology:masterfrom
sameeraleola:master
Conversation
|
You're code looks good Sameera! You've got all the required features and the stretch goals. Your code is organized in a way that makes sense and is easy to read. My main suggestion would just be to make sure you commit a little more often and write meaningful messages. Don't feel like you have to have the whole app working before you commit, just make sure it builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dillon-mce, @iyinraphael I have to practice with constraints!